Skip to content

Fix runtime crash by declaring @opentelemetry/api as required dependency - #204

Merged
bradygaster merged 1 commit into
github:mainfrom
aadnesd:patch-2
Mar 5, 2026
Merged

bradygaster merged 1 commit into
github:mainfrom
aadnesd:patch-2

Conversation

@aadnesd

@aadnesd aadnesd commented Mar 5, 2026

Copy link
Copy Markdown
Contributor

Fix runtime crash by declaring @opentelemetry/api as a runtime dependency

Problem

squad-sdk imports @opentelemetry/api at module load time (runtime path), but it is not guaranteed to be installed in fresh consumer installs.

This causes:

  • npx squad init to fail with ERR_MODULE_NOT_FOUND
  • users to manually install @opentelemetry/api as a workaround

Change

  • Add @opentelemetry/api to dependencies in packages/squad-sdk/package.json
  • Remove it from optional peer-only resolution path (if present)

Why this is correct

Because the package is imported at runtime, it must be resolvable as a runtime dependency.

Validation

  • Fresh install of @bradygaster/squad-cli
  • Run npx squad init
  • Confirm init completes without extra installs

tmcclell pushed a commit to tmcclell/squad that referenced this pull request Mar 5, 2026
M2: CI/CD publish workflows (squad-publish.yml, squad-insider-publish.yml, updated squad-ci.yml)
M3: resolveSquad() walk-up algorithm + resolveGlobalSquadPath() platform defaults + 10 tests

Closes github#202
Closes github#204
Closes github#205
Closes github#210
Closes github#211

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
@bradygaster
bradygaster merged commit 2fe5839 into github:main Mar 5, 2026
bradygaster added a commit that referenced this pull request Mar 5, 2026
Fix runtime crash by declaring @opentelemetry/api as required dependency
bradygaster added a commit that referenced this pull request Mar 5, 2026
Session: 2026-03-05T21:05Z-release-planning
Requested by: Copilot (Scribe role)

Changes:
- Logged orchestration entries for Keaton, McManus, Kobayashi, Fenster, Coordinator
- Created session log documenting v0.8.21 release planning outcomes
- Merged 3 decision inbox files into decisions.md
- Deleted inbox files (contributor page, PR merges, user directives)

Decision Merged:
- Every release MUST include contributor page update
- Workstreams MUST be included in v0.8.21

Outcomes documented:
- 4 PRs merged to dev (#204, #203, #198, #189)
- 2 issues fixed (#210, #195)
- Build passing, 98.8% test coverage
- Release scope: 18 unreleased commits
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants